Fix version in config header when used as subproject#933
Merged
Conversation
kblaschke
approved these changes
Dec 1, 2025
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Yup, that's definitely an issue that needs fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When projectM is included in another CMake project using
add_subdirectory, we will incorrectly insert the version number and commit revision of the top-level project in ourversion.hconfig header.This changes the global
CMAKE_PROJECT_VERSION*values to their localPROJECT_VERSION*equivalents for the innermost project. It will also set the working directory of the git process for determining the revision so we don't get the revision of the outer project.